IOS7: Update mouse implementation #4997
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current mouse events are handling events created from both touch and mouse input. The events have lots of logic to deal with gestures and different modes (touchpad mode, click-and-drag etc) which are not applicable for hardware inputs. Rename the current "mouse events" to "touch events" to clarify which input that triggered an event. As this is the first commit in multi- commit change, the mouse input need to use the "touch events" until a new "mouse event" is implemented.
Add input events that can be used by mouse devices, e.g. mices and touchpads. This event sends the raw input actions and doesn't care about different controller modes such as click-and-drag. Make the mouse controller utilize the new mouse input events.
The delta values are in number of pixels on the native screen resolution. Need to scale down the delta values based on the game resolution. Store reminders that are added to next deltas to mitigate "dead zones" if doing small movements.
Implement support to set the mouse pointer speed in settings. The mouse pointer speed is applied to both mouse input and touch input when in touchpad-mode.
Send relative mouse movements from backend for touch events. The relative x and y values are necessary for some games, e.g. Myst3.
Instead of having duplicated code, utilize the delta mouse function also for touches when in touchpad mode.
larsamannen
force-pushed
the
ls_more_mouse_work
branch
from
e8e2dcb to
4f777fe
Compare
sev-
approved these changes
May 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR separates touches and mouse events. Mouse events are calculated using delta values sent by the OS. The deltaX and deltaY movements have to be scaled according to the video context resolution. Else low resolution games will have faster mouse movements.
Delta values are also sent with the MOUSEMOVE events since some games depends on them (e.g. Myst 3)
Implement support of changing mouse pointer speed. This will affect connected mice, game controllers and touches when in touchpad mode.