KEMBAR78
DIRECTOR: Fixes for D5/The Cute machine by moralrecordings · Pull Request #5001 · scummvm/scummvm · GitHub
Skip to content

Conversation

@moralrecordings
Copy link
Contributor

No description provided.

By D5, titles are allowed to play back sounds on an arbitrary channel
and the mixer deals with it. This apparently works to an extent on Mac
for D4 and below, whereas Windows D4 has a hard limit of 4 channels.

As the clear intent is to play something, we should do that for all
versions, unless a counterexample shows up.

Used by Smarty.
Fixes the intro fadeout of The Cute machine.
When fading a palette, Director lets you pick a "frame rate" between 1
and 30. These each correspond to a fixed transition time, with the
higher framerates converging to zero.

In D4 and under the slowest of these frame rates is half a second.
After some user feedback they changed this in D5 to be a range
of times, ranging from a leisurely 16.5 seconds all the way to
instantaneous.

Fixes the intro fade in The Cute machine.
isChannelActive() excludes looping sounds, which are allowed to
be faded in or out.

Fixes the intro music fading in The Cute machine.
Fixes the intro music fading in The Cute machine.
Fixes several bitmaps in The Cute machine.
@sev-
Copy link
Member

sev- commented May 10, 2023

Excellent! Thank you!

@sev- sev- merged commit a379602 into scummvm:master May 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants