KEMBAR78
TITANIC: Fix -Wc++20-compat warning for the C++20 'concept' keyword by dwatteau · Pull Request #5007 · scummvm/scummvm · GitHub
Skip to content

Conversation

@dwatteau
Copy link
Contributor

This silences some identifier 'concept' is a keyword in C++20 [-Wc++20-compat] warnings when building the Titanic engine with G++ 13.

Small notes:

  • The renaming was done with Xcode contextual rename function to be sure not to make any mistake.
  • For addConcept() and removeConcept() I'm just using *c as the parameter, since the function itself reads a bit ambiguous otherwise, to me.
  • The pet_glyphs.cpp change is for an unused variable.

@bluegr
Copy link
Member

bluegr commented May 13, 2023

Thanks!

@bluegr bluegr merged commit 58ede33 into scummvm:master May 13, 2023
@dwatteau dwatteau deleted the fix/titanic-rename-concept-identifier-keyword-c++20-compat branch May 14, 2023 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants