GRAPHICS: Change pitch from int16 to int32 #5017
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is required for games allocating very big surfaces (e.g. 9000x300 in Chronicle of Innsmouth - Mountains of Madness)
|
This also fixes "Herd is Coming" (demo available on steam), which shows the exact same issue. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chronicle of Innsmouth - Mountains of Madness allocates a very big (about 9000x300) surface used for a scrolling scene.
This causes pitch to overflow in Surface::create causing a segfault as reported in 14456
Note: this does not make the game playable (yet), as it uses a still unsupported plugin to play videos and do other graphics trickery.