COMMON: Add new Rect constructors to make construction from coordinate+size easier #5045
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds some new constructors to Rect for constructing a rect from a top-left coordinate and either a bottom-right coordinate or a width and height.
Currently, this requires constructing a rect as:
Rect(coord.x, coord.y, coord.x + size.x, coord.y + size.y)Most of the subexpressions in that are duplicated, which creates opportunities for mistakes, such as when constructing multiple rects.
With this change, you construct as:
Rect(coord, coord + size)orRect(coord, size.x, size.y)This doesn't add the ability to do
Rect(coord, size)since it would have the same signature. I opted to use top-left and bottom-right coordinates given the two options, since "Point" more intuitively makes sense as a coordinate than a size.