DIRECTOR: Add multiple resources in exe using ProjectorArchive #5056
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
hari01584
commented
May 29, 2023
hari01584
commented
- Moved ProjectorArchive declaration to archive.h
- getRawExeName to get executable file name without overriding from --start-movie parameter
- Used multiarchive to detect and add resource files to searchman
This patch uses ProjectorArchive to extract multiple resources embedded into executable files, additionally a new function getRawExe is defined which gets raw exe file name without --start-movie overriding it. Solves the problem for finding multiple resource files like `ModTB.DXR` in 'mcluhan', uses 'mcluhan.exe' to extract resources and add them to SearchMan.
ProjectorArchive was giving memory leak and build failures due to not deleting unwrapped stream after use
…ully Initially for a bad file that didn't exist, the ProjectorArchive was throwing up, now however implemented gracefully loading. Fixed error and termination for `Majestic.bin`, the path it tried to look up was `Majestic` from detection entry.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.