DIRECTOR: Implement the titleVisible & modal property of window #5067
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modifies border of window by first changing title to "", then updating window border to borderType 2 `ThinNoTitle`. `titleVisible of window` to verify this behavior. Co-authored-by: Pragyansh Chaturvedi <pragyanshchaturvedi18@gmail.com>
hari01584
force-pushed
the
titlevisible_03
branch
from
a7bd4e7 to
1031618
Compare
Lockable widgets are those which takes in all input and if set then no other widget can take any input its same as them being inactive, no buttons, animations etc will work. This is implemented to support `modal` property of window, which requires a window to take all input and prevent all others from having any actions.
Implements modal property using the locking widgets of macwindowmanager. `modal of window` in 'workshop' uses this. Co-authored-by: Pragyansh Chaturvedi <pragyanshchaturvedi18@gmail.com>
|
Thanks, merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Self-explanatory.
Base work from #4114