docs(Plugin Developer Guide): More detailed lifecycle list and context descriptions #1880
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t descriptions
This commit will improve the following in the Plugin developer guide:
* Lifecyle list more complete (previous was missing some lifecycles)
* Context object has been now described in more detail per lifecycle
* Some readability/maintainability fixes to the markdown file itself
to make it easier to edit and read in an editor.
…ommits lifecycle documentation analyzeCommits lifecycle context was missing documentation for "commits" list.
gr2m
reviewed
Apr 21, 2021
|
Certainly. Will do that tomorrow! |
As per requested in the code review, the line breaks that were added in an earlier commit are now removed. While this does make reading the text just slightly more difficult (to see the whole picture), the benefit of making code reviews easier does outweight the admittedly small benefit.
|
@gr2m Sorry for the delay. Busier days than expected, but now the line breaks are removed :) |
gr2m
approved these changes
Apr 25, 2021
|
🎉 This PR is included in version 17.4.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit will improve the following in the Plugin developer guide:
to make it easier to edit and read in an editor.