chore: bump sgl-kernel 0.3.9.post2 #10311
Conversation
zhyncs
requested review from
BBuf,
FlamingoPg,
HaiShaw,
ispobock,
merrymercy and
yizhang2077
as code owners
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @zhyncs, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request performs a routine version bump for the sgl-kernel library. Its primary purpose is to update the package's declared version number, ensuring consistency across build configurations and the internal version tracking. This change is foundational and does not introduce new features or functional modifications, but rather prepares for subsequent releases or reflects minor internal updates.
Highlights
- Version Update: The sgl-kernel package version has been incremented from 0.3.9.post1 to 0.3.9.post2 across all relevant configuration and source files.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request bumps the version of sgl-kernel to 0.3.9.post2. The version number has been updated consistently across four configuration files. While the change is straightforward, I've identified a couple of areas for improvement regarding version management. Firstly, the version number is duplicated in multiple files, which can be error-prone. I've suggested centralizing it in a single file. Secondly, and more critically, I've found a potential bug in the ROCm build process where it reads the version from the wrong configuration file, which could lead to incorrect package versions. My review includes detailed comments on these points.
| [project] | ||
| name = "sgl-kernel" | ||
| version = "0.3.9.post1" | ||
| version = "0.3.9.post2" |
There was a problem hiding this comment.
There appears to be a bug in the ROCm build process regarding versioning. While this file's version is updated, the setup_rocm.py script, which is used for the ROCm build, reads the version from sgl-kernel/pyproject.toml, not this file (pyproject_rocm.toml). This means the version specified here is ignored, and the ROCm build will use the version from the main pyproject.toml file, potentially leading to incorrect versioning for ROCm packages. This should be fixed to ensure the correct version is used. The ideal solution would be to have a single source of truth for the version (e.g., python/sgl_kernel/version.py) that all build configurations use.
| [project] | ||
| name = "sgl-kernel" | ||
| version = "0.3.9.post1" | ||
| version = "0.3.9.post2" |
There was a problem hiding this comment.
To improve maintainability and prevent version inconsistencies, it's recommended to define the version in a single source of truth. Currently, the version string is duplicated across four files (pyproject.toml, pyproject_cpu.toml, pyproject_rocm.toml, and python/sgl_kernel/version.py).
A better approach would be to define the version only in python/sgl_kernel/version.py and have the build configurations read it from there dynamically.
For this file and pyproject_cpu.toml which use scikit-build-core, you can achieve this by:
- Changing
version = "..."todynamic = ["version"]under the[project]section. - Adding the following configuration under the
[tool.scikit-build]section:
[tool.scikit-build]
# ... existing settings
metadata.version.provider = "scikit_build_core.metadata.regex"
metadata.version.path = "python/sgl_kernel/version.py"This will automatically extract the version from version.py. A similar change should be applied to the ROCm build configuration to centralize version management.
1 participant
Motivation
Modifications
Accuracy Tests
Benchmarking and Profiling
Checklist