Drop conditional when verifying entry checkpoint #1917
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The log has been returning checkpoints for over a year now. Additionally, there should be no persisted bundles where the inclusion proof does not include a checkpoint, because it was marked as a required field from its inception. Signed-off-by: Hayden Blauzvern <hblauzvern@google.com>
bobcallaway
approved these changes
Dec 19, 2023
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1917 +/- ##
==========================================
- Coverage 66.40% 66.37% -0.03%
==========================================
Files 92 92
Lines 9194 9193 -1
==========================================
- Hits 6105 6102 -3
- Misses 2345 2347 +2
Partials 744 744
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The log has been returning checkpoints for over a year now. Additionally, there should be no persisted bundles where the inclusion proof does not include a checkpoint, because it was marked as a required field from its inception.
Summary
Release Note
VerifyLogEntry now requires a checkpoint to verify an inclusion proof for an entry.
Documentation