Cache checkpoint for inactive shards #2332
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Pending #2330 See the last commit for relevant changes. |
haydentherapper
force-pushed
the
cache-checkpoint
branch
from
f6fc61e to
a020b3b
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2332 +/- ##
===========================================
- Coverage 66.46% 49.88% -16.58%
===========================================
Files 92 192 +100
Lines 9258 24751 +15493
===========================================
+ Hits 6153 12348 +6195
- Misses 2359 11302 +8943
- Partials 746 1101 +355
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
haydentherapper
force-pushed
the
cache-checkpoint
branch
from
a020b3b to
4ea14fb
Compare
On service startup, Rekor will sign checkpoints for the inactive shards, since inactive tree lengths do not change. The calls to CreateAndSignCheckpoint that were not updated are because the checkpoint is being signed only for the active shard, e.g. on entry upload and when returning the active shard checkpoint. Signed-off-by: Hayden Blauzvern <hblauzvern@google.com>
Signed-off-by: Hayden Blauzvern <hblauzvern@google.com>
haydentherapper
force-pushed
the
cache-checkpoint
branch
from
4ea14fb to
0ff5059
Compare
bobcallaway
previously approved these changes
Jan 17, 2025
Signed-off-by: Hayden Blauzvern <hblauzvern@google.com>
bobcallaway
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
On service startup, Rekor will sign checkpoints for the
inactive shards, since inactive tree lengths do not
change.
The calls to CreateAndSignCheckpoint that were not
updated are because the checkpoint is being signed
only for the active shard, e.g. on entry upload
and when returning the active shard checkpoint.
Any deployment using KMS will see a reduction in KMS
calls.
Signed-off-by: Hayden Blauzvern hblauzvern@google.com
Release Note
Documentation