KEMBAR78
use correct type; just look for len() instead of nil check by bobcallaway · Pull Request #2576 · sigstore/rekor · GitHub
Skip to content

use correct type; just look for len() instead of nil check #2576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 11, 2025
Merged

use correct type; just look for len() instead of nil check #2576

merged 1 commit into from
Aug 11, 2025

Conversation

bobcallaway
Copy link
Member

Fixes: #2575

@bobcallaway
use correct type; just look for len() instead of nil check
0b73a21 
Signed-off-by: Bob Callaway <bcallaway@google.com>
@bobcallaway bobcallaway requested a review from a team as a code owner August 11, 2025 22:03
@bobcallaway bobcallaway enabled auto-merge (squash) August 11, 2025 22:03
@codecov
Copy link

codecov bot commented Aug 11, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 25.02%. Comparing base (488eb97) to head (0b73a21).
⚠️ Report is 479 commits behind head on main.

Files with missing lines Patch % Lines
pkg/api/api.go 0.00% 0 Missing and 1 partial ⚠️
pkg/api/entries.go 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff             @@
##             main    #2576       +/-   ##
===========================================
- Coverage   66.46%   25.02%   -41.44%     
===========================================
  Files          92      189       +97     
  Lines        9258    24431    +15173     
===========================================
- Hits         6153     6114       -39     
- Misses       2359    17553    +15194     
- Partials      746      764       +18
Flag Coverage Δ
e2etests 46.85% <0.00%> (-0.71%) ⬇️
unittests 16.21% <0.00%> (-31.47%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bobcallaway bobcallaway merged commit d2372a3 into sigstore:main Aug 11, 2025
16 checks passed
@BrewTestBot BrewTestBot mentioned this pull request Aug 29, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@haydentherapper haydentherapper haydentherapper approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

better handle empty argument for configured algorithms

2 participants

@bobcallaway @haydentherapper