KEMBAR78
use pubsub client to check IAM permissions by bobcallaway · Pull Request #2605 · sigstore/rekor · GitHub
Skip to content

Conversation

bobcallaway
Copy link
Member

Summary

Release Note

Documentation

Signed-off-by: Bob Callaway <bcallaway@google.com>
@bobcallaway bobcallaway requested a review from a team as a code owner September 5, 2025 13:40
@codecov
Copy link

codecov bot commented Sep 5, 2025

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 25.45%. Comparing base (488eb97) to head (5abebb3).
⚠️ Report is 512 commits behind head on main.

Files with missing lines Patch % Lines
pkg/pubsub/gcp/publisher.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #2605       +/-   ##
===========================================
- Coverage   66.46%   25.45%   -41.01%     
===========================================
  Files          92      190       +98     
  Lines        9258    25024    +15766     
===========================================
+ Hits         6153     6369      +216     
- Misses       2359    17826    +15467     
- Partials      746      829       +83     
Flag Coverage Δ
e2etests 46.36% <0.00%> (-1.20%) ⬇️
unittests 16.42% <0.00%> (-31.26%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@haydentherapper haydentherapper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FWIW, we could also consider disabling this feature. It’s not used by anyone in prod.

@bobcallaway bobcallaway merged commit 6f2044d into sigstore:main Sep 5, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants