performance enhancement for request rate limiter lua script. #3693
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: markkuang <1140387970@qq.com>
iis-MarkKuang
force-pushed
the
faster_rate_limiter_script
branch
from
f01cddc to
6e0cd81
Compare
iis-MarkKuang
changed the title
|
I see the build fails on a test case that is not relevant to the change, are there any actions required to push the PR forward? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify request rate limiter lua script,
Regression tested with RedisRateLimiterLuaScriptTests.java.
Performance tested by stress testing on my own app, with lua script changes being the only variable.
For details please check issue #3681