AddResponseHeaderGatewayFilterFactory support override option #3803
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please describe your changes and why they are needed |
|
As discussed in #3756 add new config for 'AddResponseHeaderGatewayFilter' to support the override option. |
JoeCqupt
changed the title
ryanjbaxter
reviewed
May 20, 2025
| } | ||
|
|
||
| @Override | ||
| public GatewayFilter apply(NameValueConfig config) { |
There was a problem hiding this comment.
Would it be possible to leave this apply method signature and call the new one? Trying to avoid breaking changes
Signed-off-by: jiangyuan <joe469391363@gmail.com>
Signed-off-by: jiangyuan <joe469391363@gmail.com>
JoeCqupt
force-pushed
the
add-response-feat1
branch
from
41b1943 to
c4675e4
Compare
Signed-off-by: jiangyuan <joe469391363@gmail.com>
JoeCqupt
force-pushed
the
add-response-feat1
branch
from
c4675e4 to
c99e290
Compare
JoeCqupt
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3752