Add selective namespaces to fabric8 loadbalancer #1604
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Configure Renovate
wind57
commented
Mar 18, 2024
| .withField("metadata.name", serviceName).list().getItems(); | ||
| services.forEach(service -> result.add(mapper.map(service))); | ||
| } | ||
| else if (!discoveryProperties.namespaces().isEmpty()) { |
There was a problem hiding this comment.
this is the only interesting change in this PR, where I add "selective namespace" support. Everything else are just tests: either additions or refactor of them a bit
There was a problem hiding this comment.
We could simplify this code a bit. The result.add call is the same and we could probably extract that out of this logic so we are not repeating it
There was a problem hiding this comment.
Indeed. And done, thank you
|
@ryanjbaxter ready to be looked at. thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.