KEMBAR78
Replace junit assertions by wind57 · Pull Request #1901 · spring-cloud/spring-cloud-kubernetes · GitHub
Skip to content

Conversation

@wind57
Copy link
Contributor

@wind57 wind57 commented Mar 27, 2025

No description provided.

wind57 added 2 commits March 27, 2025 14:20
1
Signed-off-by: wind57 <eugen.rabii@gmail.com>
2
Signed-off-by: wind57 <eugen.rabii@gmail.com>
wind57 added 15 commits March 27, 2025 16:37
Signed-off-by: wind57 <eugen.rabii@gmail.com>
Signed-off-by: wind57 <eugen.rabii@gmail.com>
Signed-off-by: wind57 <eugen.rabii@gmail.com>
Signed-off-by: wind57 <eugen.rabii@gmail.com>
Signed-off-by: wind57 <eugen.rabii@gmail.com>
Signed-off-by: wind57 <eugen.rabii@gmail.com>
Signed-off-by: wind57 <eugen.rabii@gmail.com>
Signed-off-by: wind57 <eugen.rabii@gmail.com>
Signed-off-by: wind57 <eugen.rabii@gmail.com>
Signed-off-by: wind57 <eugen.rabii@gmail.com>
Signed-off-by: wind57 <eugen.rabii@gmail.com>
@wind57 wind57 marked this pull request as ready for review April 3, 2025 12:53
@wind57
Copy link
Contributor Author

wind57 commented Apr 3, 2025

@ryanjbaxter I dont know how you are looking at this, but I replaced junit assertions with the ones from asserj, so that we have a single way to do the tests...

@ryanjbaxter
Copy link
Contributor

Huh...I thought we had a checkstyle rule for this 🧐

Either way thanks!

@ryanjbaxter ryanjbaxter added this to the 3.1.6 milestone Apr 3, 2025
@ryanjbaxter ryanjbaxter merged commit 717a526 into spring-cloud:3.1.x Apr 3, 2025
17 checks passed
@github-project-automation github-project-automation bot moved this to Done in 2023.0.6 Apr 3, 2025
@spencergibb spencergibb moved this to Done in 2024.0.2 Jul 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

No open projects
Status: Done
Status: Done
Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants