KEMBAR78
Fix simple typo on Configuration Properties page by djkeh · Pull Request #993 · spring-cloud/spring-cloud-openfeign · GitHub
Skip to content

Conversation

@djkeh
Copy link
Contributor

@djkeh djkeh commented Feb 22, 2024

This pr fixes typo in description of the configuration property spring.cloud.openfeign.circuitbreaker.group.enabled.
Thanks.

@pivotal-cla
Copy link

@djkeh Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@pivotal-cla
Copy link

@djkeh Thank you for signing the Contributor License Agreement!

Copy link
Collaborator

@OlgaMaciaszek OlgaMaciaszek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @djkeh. Thanks for the contribution. This file is auto-generated. You need to change it in spring-cloud-openfeign-core/src/main/resources/META-INF/additional-spring-configuration-metadata.json instead. Then you can just run ./mvnw clean install -Pdocs to regenerate this file.

@djkeh
Copy link
Contributor Author

djkeh commented Mar 19, 2024

Thanks @OlgaMaciaszek, I understood and fixed the typo using the right way.

@OlgaMaciaszek OlgaMaciaszek added this to the 4.1.1 milestone Mar 20, 2024
Copy link
Collaborator

@OlgaMaciaszek OlgaMaciaszek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @djkeh. LGTM.

@OlgaMaciaszek OlgaMaciaszek merged commit 6ff55e3 into spring-cloud:main Mar 20, 2024
@djkeh djkeh deleted the fix-typo branch March 20, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants