KEMBAR78
Fix issues when building SWS without default features by joseluisq · Pull Request #480 · static-web-server/static-web-server · GitHub
Skip to content

Conversation

@joseluisq
Copy link
Collaborator

Description

This PR fixes issues when building SWS without default features in a library context.

Now, either cargo test --tests --no-default-features, cargo run --no-default-features -- -h or cargo build --release --no-default-features -vv will work as expected.

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

@joseluisq joseluisq added v2 v2 release bugfix This is PR fixes a bug library Related to the static-web-server crate labels Sep 9, 2024
@joseluisq joseluisq self-assigned this Sep 9, 2024
@semanticdiff-com
Copy link

semanticdiff-com bot commented Sep 9, 2024

Review changes with SemanticDiff.

Analyzed 9 of 11 files.

Overall, the semantic diff is 12% smaller than the GitHub diff.

Filename Status
✔️ tests/compression.rs Analyzed
✔️ tests/compression_static.rs 30.65% smaller
✔️ tests/handler.rs Analyzed
✔️ tests/static_files.rs 21.92% smaller
✔️ src/http_ext.rs Analyzed
✔️ src/lib.rs Analyzed
✔️ src/server.rs 14.74% smaller
✔️ src/static_files.rs 33.52% smaller
✔️ src/headers_ext/mod.rs Analyzed
docs/content/building-from-source.md Unsupported file format
.github/workflows/devel.yml Unsupported file format

@joseluisq joseluisq force-pushed the fix-issue-building-without-default-features branch from 38c9573 to 80f3126 Compare September 9, 2024 23:42
@joseluisq joseluisq merged commit a3d40b8 into master Sep 10, 2024
34 checks passed
@joseluisq joseluisq deleted the fix-issue-building-without-default-features branch September 10, 2024 13:28
@joseluisq joseluisq added this to the v2.33.0 milestone Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix This is PR fixes a bug library Related to the static-web-server crate v2 v2 release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant