KEMBAR78
Improve docs configuration and fix anchor links by mschoettle · Pull Request #504 · static-web-server/static-web-server · GitHub
Skip to content

Conversation

@mschoettle
Copy link
Contributor

Description

Resolves all info/warnings output by mkdocs.

Adds --strict to the deploy command. Validation by mkdocs set to warn.

Related Issue

Motivation and Context

Building the documentation site showed some issues with non-existent anchors. mkdocs can treat such things as warnings which makes it more visible and building with --strict can fail the build process. This helps find issues quicker.

How Has This Been Tested?

mkdocs build --strict

Screenshots (if appropriate):

@semanticdiff-com
Copy link

Review changes with  SemanticDiff

@joseluisq joseluisq added documentation Improvements or additions to documentation enhancement New feature or request v2 v2 release labels Nov 29, 2024
Copy link
Collaborator

@joseluisq joseluisq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the idea. I just found a minor improvement to make.

@mschoettle mschoettle changed the title Fix anchor links in documentation docs: fix anchor links Dec 1, 2024
@mschoettle mschoettle requested a review from joseluisq December 1, 2024 11:41
Copy link
Collaborator

@joseluisq joseluisq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@joseluisq joseluisq merged commit 12387a8 into static-web-server:master Dec 1, 2024
24 checks passed
@joseluisq joseluisq added this to the v2.34.0 milestone Dec 1, 2024
@mschoettle mschoettle deleted the improve-docs branch December 1, 2024 12:26
@joseluisq joseluisq changed the title docs: fix anchor links Improve docs configuration and fix anchor links Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation enhancement New feature or request v2 v2 release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants