KEMBAR78
The closing body tag has been moved right before the closing html tag by alxv-su · Pull Request #511 · static-web-server/static-web-server · GitHub
Skip to content

Conversation

@alxv-su
Copy link
Contributor

@alxv-su alxv-su commented Dec 10, 2024

It was a mistake in the html hierarhy: the body contained only h1 tag.

Description

I moved closing body tag right before closing html tag.

Related Issue

It is too obvious to create an issue.

Motivation and Context

Compliance with HTML specification.

How Has This Been Tested?

I checked source code of directory listing returned by fixed static-web-server using https://validator.w3.org/nu/#textarea

@semanticdiff-com
Copy link

semanticdiff-com bot commented Dec 10, 2024

Review changes with  SemanticDiff

Changed Files
File Status
  src/directory_listing.rs  97% smaller

@joseluisq joseluisq added v2 v2 release bugfix This is PR fixes a bug labels Dec 10, 2024
Copy link
Collaborator

@joseluisq joseluisq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! Please just resolve the minor formatting suggestions.

Copy link
Collaborator

@joseluisq joseluisq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@joseluisq joseluisq merged commit 206900b into static-web-server:master Dec 10, 2024
26 checks passed
@joseluisq joseluisq modified the milestones: v2.34.1, v2.35.0 Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bugfix This is PR fixes a bug v2 v2 release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants