[link] Web auth fallback #11571
Merged
[link] Web auth fallback #11571
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Diffuse output: APKDEX |
lng-stripe
commented
Sep 12, 2025
| @Parcelize | ||
| @RestrictTo(RestrictTo.Scope.LIBRARY_GROUP) | ||
| @Serializable | ||
| data class DisplayablePaymentDetails( |
There was a problem hiding this comment.
👀 Moved to its own file
|
|
||
| @Suppress("CyclomaticComplexMethod", "ComplexCondition") | ||
| private suspend fun updateScreenState(withAnimationDelay: Boolean) { | ||
| private suspend fun updateScreenState( |
There was a problem hiding this comment.
👀 I gave this code a significant makeover in order to improve readability. It might still be hard to follow because of the inherent complexity, but hopefully it's better. Most of the existing behavior shouldn't have changed, which the tests cover.
There was a problem hiding this comment.
this is amazing, very needed.
| } | ||
|
|
||
| @VisibleForTesting | ||
| internal fun getScreenStateForAuthorizationAfterRefresh( |
There was a problem hiding this comment.
Can we add docs for this function? just to clarify that it can either return a next screen, or just return null and dismiss internally.
Comment on lines
406
to
422
| // Launch web auth flow if web auth URL is available. | ||
| // Next steps will happen in `handleWebAuthActivityResult`. | ||
| if (accountStatus.webviewOpenUrl != null) { | ||
| launchWebAuthFlow?.invoke(accountStatus.webviewOpenUrl) | ||
| return |
lng-stripe
requested review from
carlosmuvi-stripe,
mats-stripe and
tillh-stripe
| consumerPublishableKey = linkAccount.consumerPublishableKey | ||
| ) | ||
| .onFailure { error -> | ||
| linkEventsReporter.onAccountLookupFailure(error) |
There was a problem hiding this comment.
[no action] This is not a lookup call right? we might want to have a specific event for this (can be a follow-up)
| } | ||
|
|
||
| @VisibleForTesting | ||
| internal fun getScreenStateForAuthorizationAfterRefresh( |
There was a problem hiding this comment.
Can we add docs for this function? just to clarify that it can either return a next screen, or just return null and dismiss internally.
lng-stripe
force-pushed
the
lng/link-web-auth-fallback
branch
2 times, most recently
from
5579982 to
1939cea
Compare
|
I updated it so web auth is mostly handled in Verification instead. This has the benefits of:
|
lng-stripe
force-pushed
the
lng/link-web-auth-fallback
branch
from
1939cea to
5228e09
Compare
|
Still in draft because it's blocked on changes to the |
|
Backend changes were deployed. Pushed some minor-ish changes and updated the PR description with videos from manual testing. |
| private val dismissWithResult: (LinkActivityResult) -> Unit, | ||
| ) : ViewModel() { | ||
|
|
||
| private val isProcessingWebAuth = linkAccount.webviewOpenUrl != null |
There was a problem hiding this comment.
nit - should we keep this only on the state to avoid confusion?
|
|
||
| private fun startWebVerification() { | ||
| viewModelScope.launch { | ||
| // If the web auth URL has already been consumed, perform lookup again to get a fresh one. |
There was a problem hiding this comment.
we can maybe mention that auth web urls cannot be reused, for context
|
|
||
| @Suppress("CyclomaticComplexMethod", "ComplexCondition") | ||
| private suspend fun updateScreenState(withAnimationDelay: Boolean) { | ||
| private suspend fun updateScreenState( |
There was a problem hiding this comment.
this is amazing, very needed.
carlosmuvi-stripe
previously approved these changes
Sep 17, 2025
carlosmuvi-stripe
approved these changes
Sep 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fall back to web auth when required. High-level summary of how it works:
link-popup://...URI that the SDK will interceptMotivation
It won't be SMS only forever.
Testing
Screenshots
Recordings of various flows below
Screen.Recording.2025-09-17.at.12.51.33.PM-compressed.mov
Screen.Recording.2025-09-17.at.12.28.09.PM-compressed.mov
Screen.Recording.2025-09-17.at.12.23.21.PM-compressed.mov
Screen.Recording.2025-09-17.at.12.22.16.PM-compressed.mov