Add Types for Billing Details in Payment Element Change Event #770
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dali-stripe
approved these changes
Jul 11, 2025
| type: string; | ||
| billingDetails?: { | ||
| address: { | ||
| country?: null | string; |
There was a problem hiding this comment.
just wondering about the undefined vs null compared to the billing_details definition below...?
There was a problem hiding this comment.
These values can definitely be undefined since we will deliberately not be showing postalCode for countries where the postal code input is not rendering, which is different than how payment_method is doing it where they're defaulting to null
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & motivation
Add Billing Details Type for Payment Element Change Event
Testing & documentation