Add typings for confirmBilliePayment function #773
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dodgez-stripe @graceg-stripe @dali-stripe any chance to get some eyes on this? 🙏 |
dali-stripe
previously approved these changes
Jun 30, 2025
graceg-stripe
previously approved these changes
Jul 2, 2025
|
(rebased on latest |
graceg-stripe
approved these changes
Jul 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & motivation
This PR adds typings for the
confirmBilliePaymentfunction, used to confirm a Billie payment.Testing & documentation
I tested this change by using it in our test-environment web app, where I have now added support for Billie. In order to test, I ran
yarn buildand manually copied thedistfolder intonode_modules/@stripe/stripe-js/dist.Please let me know if there is anything else that needs to be done! We are trying to roll out Billie to one of our customers asap, and having them work on web (in addition to native) is one step on the way.
This is the same as #760, which was closed by the stale bot 😢