[breaking] Update types for Checkout SDK #803
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pololi-stripe
force-pushed
the
pololi/add-clover-custom-checkout-sdk-types
branch
3 times, most recently
from
dbd131f to
c1425a5
Compare
pololi-stripe
changed the title
pololi-stripe
force-pushed
the
pololi/add-clover-custom-checkout-sdk-types
branch
from
c1425a5 to
4fa8512
Compare
| * Contact [Stripe support](https://support.stripe.com/) for more information. | ||
| */ | ||
| initCheckout(options: StripeCheckoutOptions): Promise<StripeCheckout>; | ||
| initCheckout(options: StripeCheckoutOptions): StripeCheckout; |
There was a problem hiding this comment.
While we're here, can we remove the beta access notice 😄
|
|
||
| export interface StripeCheckout { | ||
| /* Custom Checkout methods */ | ||
| type LoadActionsError = {message: string; code: null}; |
There was a problem hiding this comment.
Should code be code: string | null?
There was a problem hiding this comment.
No, I think the idea is to be explicit about the error.code here.
Similar to other
stripe-js/types/stripe-js/checkout.d.ts
Lines 534 to 536 in 0718c41
Right now, we don't have a concrete code and only has null
We can add specific ones when we introduce them in the future.
jackieosborn-stripe
approved these changes
Sep 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary & motivation
Update types for Checkout SDK.
Testing & documentation
API Review: Custom Checkout init parallelization
API Review: Custom Checkout improvements (react-stripe-js, clientSecret promise)