KEMBAR78
Test with pytest by adamchainz · Pull Request #89 · svenkreiss/html5validator · GitHub
Skip to content

Conversation

@adamchainz
Copy link
Contributor

Required for running on Python 3.10, where nose doesn’t work. Nose has not seen a release in 6 years, so it's unlikely to become compatible.

Required for running on Python 3.10, where nose doesn’t work. Nose has not seen a release in 6 years, so it's unlikely to become compatible.
Copy link
Contributor

@Cyb3r-Jak3 Cyb3r-Jak3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a switch over as I have switched to pytest for local testing.

@svenkreiss
Copy link
Owner

I'd feel better if the tests in the Github Actions had actually run. Anyone any idea why that didn't happen for this PR?

@svenkreiss svenkreiss merged commit 7d4b8d2 into svenkreiss:main Apr 6, 2022
@adamchainz adamchainz deleted the test_pytest branch April 6, 2022 16:46
@adamchainz
Copy link
Contributor Author

Did it need approval? It seems to be running on main after merge.

@adamchainz adamchainz mentioned this pull request Apr 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants