Count regular edges while picking metaedge. #1082
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The logic for patching inputs to function nodes performs a scan across metaedges (edges that encapsulate potentially numerous base edges) in order to determine the correct metaedge to patch. Previously, this logic had not taken into consideration how a metaedge could represent several regular edges. This was problematic since the index pertained to the collective number of regular edges (not metaedges). This had caused an internal user's graph to fail to render. The graph contained an edge into a series node within a function. The series node caused several regular edges to be collapsed into one metaedge. This change has been tested with that graph as well as other graphs that make use of TensorFlow functions. The graph WAI.
nfelt
approved these changes
Mar 28, 2018
| let originalMetaEdge: Metaedge; | ||
| let regularEdgeCount = 0; | ||
| for (let i = 0; i < originalMetaEdges.regular.length; i++) { | ||
| const metaEdge = originalMetaEdges.regular[i]; |
There was a problem hiding this comment.
Optional - this could be a forEach, right? Since you aren't using the index variable except to index into the original list.
There was a problem hiding this comment.
Yes! Thanks! We now use _.each.
|
LGTM, shall we merge? We'll want to do a sync too. I think the Beholder stuff was still an issue; I can take a look at this if nobody else is working on it. @jart cc |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The logic for patching inputs to function nodes performs a scan across
metaedges (edges that encapsulate potentially numerous base edges) in
order to determine the correct metaedge to patch. Previously, this logic
had not taken into consideration how a metaedge could represent several
regular edges. This was problematic since the index pertained to the
collective number of regular edges (not metaedges).
This had caused an internal user's graph to fail to render. The graph
contained an edge into a series node within a function. The series node
caused several regular edges to be collapsed into one metaedge.
This change has been tested with that graph as well as other graphs that
make use of TensorFlow functions. The graph WAI.
This logic will be tested within internal integration tests for the graph.