Fixed the dangling interaction issue #1287
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Interactions do not get destroyed or deactivated automatically even if a component it is attached to is detached from DOM. As a result, event listeners were eagerly listening to mouse events and expected a component to be mounted. Cleaned up vz-line-chart a bit by factoring interaction out of tooltip rendering. Interaction is supposed to be reused over time.
nfelt
approved these changes
Jul 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Interactions do not get destroyed or deactivated automatically
even if a component it is attached to is detached from DOM. As
a result, event listeners were eagerly listening to mouse events
and expected a component to be mounted.
Cleaned up vz-line-chart a bit by factoring interaction out of
tooltip rendering. Interaction is supposed to be reused over
time.