KEMBAR78
add capture-profile into profile plugin by qqfish · Pull Request #1894 · tensorflow/tensorboard · GitHub
Skip to content

add capture-profile into profile plugin #1894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Mar 14, 2019
Merged

add capture-profile into profile plugin #1894

merged 5 commits into from
Mar 14, 2019

Conversation

@qqfish
Copy link

@qqfish qqfish commented Feb 26, 2019 •
edited by stephanwlee
Loading

  • Motivation for features / changes
    Allow sending capture profile request via TB

  • Screenshots of UI changes
    image

@qqfish
Copy link
Author

qqfish commented Feb 26, 2019

Screenshot:
image

stephanwlee
stephanwlee reviewed Feb 26, 2019
View reviewed changes
@qqfish qqfish force-pushed the fishx-capture-profile branch 4 times, most recently from f224d14 to 15ddbb5 Compare February 26, 2019 23:26
stephanwlee
stephanwlee reviewed Feb 27, 2019
View reviewed changes
@qqfish qqfish force-pushed the fishx-capture-profile branch from 15ddbb5 to 8773fec Compare February 27, 2019 23:47
@qqfish qqfish force-pushed the fishx-capture-profile branch from 8773fec to 4634011 Compare March 7, 2019 21:03
stephanwlee
stephanwlee reviewed Mar 8, 2019
View reviewed changes
tensorboard/plugins/profile/profile_plugin.py Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh interesting, didn't realize there is no way to stop and have to wait for that duration. Just curious, why?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Separately, I am pondering the implication of using self.logdir here. Are profile data tagged with timestamp or anything? Would one be able to make any sense of the name when user profiles multiple times?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. I think it is fine to block the thread since python server uses different multiple threads to handle request.
  2. Profile data are tagged with timestamp.

stephanwlee
stephanwlee approved these changes Mar 14, 2019
View reviewed changes
tensorboard/plugins/profile/tf_profile_dashboard/tf-profile-dashboard.html Outdated
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm I did not realize this soon enough. I generally am scared of holding request open for at least a duration of the profile. Any thoughts on changing this contract so FE starts, polls (presumably with some status about the profile like memory usage), and stop?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it could be a future improvement. Created an issue #2013 to track it.

@qqfish qqfish force-pushed the fishx-capture-profile branch from de6cf12 to e9c47d2 Compare March 14, 2019 18:02
@stephanwlee stephanwlee merged commit d612afc into tensorflow:master Mar 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stephanwlee stephanwlee stephanwlee approved these changes

@qiuminxu qiuminxu qiuminxu left review comments

Assignees

No one assigned

Labels

plugin:profile

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@qqfish @stephanwlee @qiuminxu