-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Add a pod viewer tool for analyzing TPU pod performance. #2111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Skimmed and most comments are stylistic nits.
hloandEleseem to mean something important but I do not know what that would be. What do they mean?- can you make sure the new license preambles are correct?
- for TypeScript files, can you add as much types as possible?
tensorboard/plugins/profile/pod_viewer/details_card/details-card.html
Outdated
Show resolved
Hide resolved
tensorboard/plugins/profile/pod_viewer/details_card/details-card.html
Outdated
Show resolved
Hide resolved
tensorboard/plugins/profile/pod_viewer/details_card/details-card.html
Outdated
Show resolved
Hide resolved
tensorboard/plugins/profile/pod_viewer/details_card/details-card.html
Outdated
Show resolved
Hide resolved
tensorboard/plugins/profile/pod_viewer/details_card/details-card.ts
Outdated
Show resolved
Hide resolved
tensorboard/plugins/profile/pod_viewer/details_card/details-card.ts
Outdated
Show resolved
Hide resolved
tensorboard/plugins/profile/pod_viewer/details_card/details-card.ts
Outdated
Show resolved
Hide resolved
tensorboard/plugins/profile/pod_viewer/pod_viewer_dashboard/pod-viewer-dashboard.html
Outdated
Show resolved
Hide resolved
tensorboard/plugins/profile/pod_viewer/pod_viewer_dashboard/pod-viewer-dashboard.html
Outdated
Show resolved
Hide resolved
tensorboard/plugins/profile/pod_viewer/pod_viewer_dashboard/pod-viewer-dashboard.html
Outdated
Show resolved
Hide resolved
tensorboard/plugins/profile/pod_viewer/pod_viewer_dashboard/pod-viewer-dashboard.ts
Outdated
Show resolved
Hide resolved
tensorboard/plugins/profile/pod_viewer/pod_viewer_dashboard/pod-viewer-dashboard.ts
Outdated
Show resolved
Hide resolved
tensorboard/plugins/profile/pod_viewer/pod_viewer_dashboard/pod-viewer-dashboard.ts
Outdated
Show resolved
Hide resolved
tensorboard/plugins/profile/pod_viewer/pod_viewer_dashboard/pod-viewer-dashboard.ts
Outdated
Show resolved
Hide resolved
tensorboard/plugins/profile/pod_viewer/pod_viewer_dashboard/pod-viewer-dashboard.ts
Outdated
Show resolved
Hide resolved
tensorboard/plugins/profile/pod_viewer/topology_graph/topology-graph.ts
Outdated
Show resolved
Hide resolved
tensorboard/plugins/profile/pod_viewer/topology_graph/topology-graph.ts
Outdated
Show resolved
Hide resolved
tensorboard/plugins/profile/pod_viewer/topology_graph/topology-graph.ts
Outdated
Show resolved
Hide resolved
tensorboard/plugins/profile/pod_viewer/topology_graph/topology-graph.ts
Outdated
Show resolved
Hide resolved
tensorboard/plugins/profile/pod_viewer/topology_graph/topology-graph.ts
Outdated
Show resolved
Hide resolved
tensorboard/plugins/profile/pod_viewer/details_card/details-card.ts
Outdated
Show resolved
Hide resolved
tensorboard/plugins/profile/pod_viewer/details_card/details-card.ts
Outdated
Show resolved
Hide resolved
tensorboard/plugins/profile/pod_viewer/pod_viewer_dashboard/pod-viewer-dashboard.ts
Outdated
Show resolved
Hide resolved
tensorboard/plugins/profile/pod_viewer/pod_viewer_dashboard/pod-viewer-dashboard.ts
Outdated
Show resolved
Hide resolved
tensorboard/plugins/profile/pod_viewer/pod_viewer_dashboard/pod-viewer-dashboard.ts
Outdated
Show resolved
Hide resolved
tensorboard/plugins/profile/pod_viewer/pod_viewer_dashboard/pod-viewer-dashboard.ts
Outdated
Show resolved
Hide resolved
tensorboard/plugins/profile/pod_viewer/pod_viewer_dashboard/pod-viewer-dashboard.ts
Outdated
Show resolved
Hide resolved
tensorboard/plugins/profile/pod_viewer/pod_viewer_dashboard/pod-viewer-dashboard.ts
Outdated
Show resolved
Hide resolved
|
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the ℹ️ Googlers: Go here for more info. |
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally, I want to see
- proper syntax for denoting private property
- use more computed property instead of using an observer to update bunch of properties
- correct Polymer property default value provider (e.g.,
value: () => [],) - code style (whitespaces mostly)
- Please refer to style guides: https://google.github.io/styleguide/htmlcssguide.html
tensorboard/plugins/profile/pod_viewer/pod_viewer_dashboard/pod-viewer-dashboard.html
Outdated
Show resolved
Hide resolved
tensorboard/plugins/profile/pod_viewer/pod_viewer_dashboard/pod-viewer-dashboard.html
Outdated
Show resolved
Hide resolved
tensorboard/plugins/profile/pod_viewer/pod_viewer_dashboard/pod-viewer-dashboard.html
Outdated
Show resolved
Hide resolved
tensorboard/plugins/profile/pod_viewer/pod_viewer_dashboard/pod-viewer-dashboard.ts
Outdated
Show resolved
Hide resolved
tensorboard/plugins/profile/pod_viewer/pod_viewer_dashboard/pod-viewer-dashboard.ts
Outdated
Show resolved
Hide resolved
tensorboard/plugins/profile/pod_viewer/pod_viewer_dashboard/pod-viewer-dashboard.ts
Outdated
Show resolved
Hide resolved
tensorboard/plugins/profile/pod_viewer/pod_viewer_dashboard/pod-viewer-dashboard.ts
Outdated
Show resolved
Hide resolved
tensorboard/plugins/profile/pod_viewer/pod_viewer_dashboard/pod-viewer-dashboard.ts
Outdated
Show resolved
Hide resolved
tensorboard/plugins/profile/pod_viewer/pod_viewer_dashboard/pod-viewer-dashboard.ts
Outdated
Show resolved
Hide resolved
tensorboard/plugins/profile/pod_viewer/stack_bar_chart/stack-bar-chart.ts
Outdated
Show resolved
Hide resolved
tensorboard/plugins/profile/pod_viewer/details_card/details-card.ts
Outdated
Show resolved
Hide resolved
tensorboard/plugins/profile/pod_viewer/details_card/details-card.ts
Outdated
Show resolved
Hide resolved
tensorboard/plugins/profile/pod_viewer/pod_viewer_common/proto.ts
Outdated
Show resolved
Hide resolved
tensorboard/plugins/profile/pod_viewer/pod_viewer_common/proto.ts
Outdated
Show resolved
Hide resolved
tensorboard/plugins/profile/pod_viewer/details_card/details-card.ts
Outdated
Show resolved
Hide resolved
tensorboard/plugins/profile/pod_viewer/pod_viewer_dashboard/pod-viewer-dashboard.html
Outdated
Show resolved
Hide resolved
tensorboard/plugins/profile/pod_viewer/pod_viewer_dashboard/pod-viewer-dashboard.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this PR now is in better shape then ever!
There are few stylistic nits and questions posed. After that, I think we are almost done!
tensorboard/plugins/profile/pod_viewer/pod_viewer_dashboard/pod-viewer-dashboard.html
Outdated
Show resolved
Hide resolved
tensorboard/plugins/profile/pod_viewer/pod_viewer_dashboard/pod-viewer-dashboard.ts
Outdated
Show resolved
Hide resolved
tensorboard/plugins/profile/pod_viewer/pod_viewer_dashboard/pod-viewer-dashboard.ts
Outdated
Show resolved
Hide resolved
tensorboard/plugins/profile/pod_viewer/pod_viewer_dashboard/pod-viewer-dashboard.ts
Outdated
Show resolved
Hide resolved
tensorboard/plugins/profile/pod_viewer/pod_viewer_dashboard/pod-viewer-dashboard.ts
Outdated
Show resolved
Hide resolved
tensorboard/plugins/profile/pod_viewer/topology_graph/topology-graph.ts
Outdated
Show resolved
Hide resolved
tensorboard/plugins/profile/pod_viewer/topology_graph/topology-graph.ts
Outdated
Show resolved
Hide resolved
tensorboard/plugins/profile/pod_viewer/topology_graph/topology-graph.ts
Outdated
Show resolved
Hide resolved
tensorboard/plugins/profile/pod_viewer/topology_graph/topology-graph.ts
Outdated
Show resolved
Hide resolved
tensorboard/plugins/profile/pod_viewer/topology_graph/topology-graph.ts
Outdated
Show resolved
Hide resolved
tensorboard/plugins/profile/pod_viewer/pod_viewer_dashboard/pod-viewer-dashboard.ts
Outdated
Show resolved
Hide resolved
tensorboard/plugins/profile/pod_viewer/pod_viewer_dashboard/pod-viewer-dashboard.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working through the review. Code looks much readable now!
|
Thank you for the thorough review and many great suggestions!! |
Motivation for features / changes
As TPU pod is provided to cloud TPU users, we need to tool to provide a global visualization of the performance of each core, as well as the communication across the cores for your system.
Technical description of changes
The pod viewer UI shows:
Screenshots of UI changes
Detailed steps to verify changes work correctly (as executed by you)