KEMBAR78
Fix word-break issue on metadata card by cannoneyed · Pull Request #2198 · tensorflow/tensorboard · GitHub
Skip to content

Conversation

@cannoneyed
Copy link
Contributor

Long strings in metadata were incorrectly overflowing the metadata card. Since the element is styled as a table, we need to use word-break rather than overflow-wrap.

before
Screen Shot 2019-05-06 at 3 14 42 PM

after
Screen Shot 2019-05-06 at 3 14 50 PM

@stephanwlee
Copy link
Contributor

stephanwlee commented May 6, 2019

Since the element is styled as a table, we need to use word-break rather than overflow-wrap

I am not too familiar with this perhaps because the table wasn't too popular when I actively developed. Would you have a reference handy?

Also, would setting a concrete width on the table help?

@cannoneyed
Copy link
Contributor Author

Yeah I'm not really that familiar with this styling approach either... had to do quite a bit of digging / experimenting to finally figure out how to make it work. Sadly I don't have a great reference for exactly what's going on here, but there are a few things I found that led me to this solution 9https://gist.github.com/prabhuramkumar/4491951)

Also, setting a concrete width on the table does NOT work, unfortunately (which was very frustrating)

@stephanwlee
Copy link
Contributor

Can you please provide me with a sample data I can use to reproduce the bug? I cannot reproduce this by simply patching the DOM, thanks!

@cannoneyed
Copy link
Contributor Author

Here's what I did to address it: Add the following to /tensorboard/plugins/projector/vz_projector/standalone_projector_config.json

    {
      "bookmarksPath": "http://projector.tensorflow.org/oss_data/bnmt_enjako_interlingua_10k_1024_bookmarks.txt",
      "metadataPath": "http://projector.tensorflow.org/oss_data/bnmt_enjako_interlingua_10k_1024_metadata.tsv",
      "tensorName": "GNMT Interlingua",
      "tensorPath": "http://projector.tensorflow.org/oss_data/bnmt_enjako_interlingua_10k_1024_tensors.bytes",
      "tensorShape": [9978, 1024]
    }

@stephanwlee stephanwlee merged commit 895799e into tensorflow:master Jun 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants