Zoom with mouse wheel only when alt key is pressed #2221
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Default mouse wheel to zoom is rather obnoxious since large area of the TensorBoard is zoomable area. Fixes tensorflow#2214.
nfelt
approved these changes
May 24, 2019
|
I will work on quick follow up to add the Google Map like help when user wheels without pressing alt. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Default mouse wheel to zoom is rather obnoxious since large area of the
TensorBoard is zoomable area.
Note that preferably we'd want to provide some tooltip or help to make
this feature discoverable but simple hack using
HTMLElement.titlefelt verydisturbing and poor. We, in later time, might want to consider doing what
Google Map does on mobile (when scroll event happens inside the zoomable
area, it shows shows a transparent splash describing how to zoom). Note that
none of these solutions are friendly to the screen reader softwares.
Fixes #2214.