Add PR curves and F1 score to WIT #2264
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tolga-b please review |
stephanwlee
approved these changes
May 23, 2019
| <div class="perf-table-num-entry">[[getAccuracyModelIndex(inferenceStats_, featureValueThreshold.threshold, index, featureValueThreshold)]]</div> | ||
| </template> | ||
| </div> | ||
| <div class="perf-table-f1 perf-table-clickable" on-tap="togglePerfRow"> |
There was a problem hiding this comment.
No action required (since we really don't honor this): a div that is clickable is not really accessible. At the very least, we should put tab-index="-1" (and of course role=button)
| if (Object.keys(confCounts).length == 0) { | ||
| return 0; | ||
| } | ||
| if (confCounts['Yes']['Yes'] == 0) { |
There was a problem hiding this comment.
might be more readable (or more maintainable) to assign this to a variable.
const truePositive = confCoujnts['Yes']['Yes'];
...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per user requests, adding PR curves and F1 score to performance tab of WIT for binary classification models.
Ran binary classification demos (single and multimodel) to visualize change and ensure correctness.