core: split magic --logdir_spec out from verbatim --logdir
#2664
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: This introduces a new flag, `--logdir_spec`, whose behavior is the same as the old behavior of `--logdir`. The `--logdir` flag now specifies a single log directory, without special treatment for commas and colons, though it still has the `expanduser` call for compatibility with users who use the `--logdir=~/...` form rather than `--logdir ~/...`. I audited all uses of `flags.logdir` and `context.logdir`, and, other than those changed in this commit, all really should be using `logdir` rather than `logdir_spec` (i.e., they do not properly parse the logdir spec, and so were broken before this commit). Fixes #2615, fixes #1220, and fixes lots of user confusion. Test Plan: Run with the following args: --logdir ~/data/ # should work as usual --logdir=~/data/ # should work as usual --logdir ~/data/scalars_demo,~/data/audio_demo # should be empty --logdir ~/data/mnist/lr_1E-03,conv=1,fc=2 # should work now! --logdir_spec ~/data/ # should work, but without projector, et al. --logdir_spec ~/data/scalars_demo,~/data/audio_demo # should work wchargin-branch: logdir-spec
nfelt
approved these changes
Sep 18, 2019
tensorboard/plugins/base_plugin.py
Outdated
| logdir: The string logging directory TensorBoard was started with. If this | ||
| is set, the db_uri should be None. | ||
| logdir: The string logging directory TensorBoard was started with. | ||
| logdir_spec: The value of `--logdir_spec` passed to TensorBoard (see |
There was a problem hiding this comment.
Let's just have the data location handler consult context.flags.logdir_spec directly, even though it's uglier, to avoid presenting logdir_spec as something that plugin implementers can depend on. (If we did want them to use it we'd probably want to pass it to them in parsed form, not the colon and comma delimited form.)
wchargin-branch: logdir-spec wchargin-source: 718e5d26402863cf144acb4df4a5a05ca0cabb0a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This introduces a new flag,
--logdir_spec, whose behavior is the sameas the old behavior of
--logdir. The--logdirflag now specifies asingle log directory, without special treatment for commas and colons,
though it still has the
expandusercall for compatibility with userswho use the
--logdir=~/...form rather than--logdir ~/....I audited all uses of
flags.logdirandcontext.logdir, and, otherthan those changed in this commit, all really should be using
logdirrather than
logdir_spec(i.e., they do not properly parse the logdirspec, and so were broken before this commit).
Fixes #2615, fixes #1220, and fixes lots of user confusion.
Test Plan:
Run with the following args:
wchargin-branch: logdir-spec