KEMBAR78
summary: export v2 symbols as defaults by stephanwlee · Pull Request #2670 · tensorflow/tensorboard · GitHub
Skip to content

summary: export v2 symbols as defaults #2670

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 18, 2019
Merged

summary: export v2 symbols as defaults #2670

merged 3 commits into from
Sep 18, 2019

Conversation

@stephanwlee
Copy link
Contributor

@stephanwlee stephanwlee commented Sep 18, 2019 •
edited by nfelt
Loading

This change is for readiness of TensorBoard 2.0 release.
In 2.0, tensorboard.summary should default to v2 symbols.

Fixes #2512

@stephanwlee stephanwlee requested review from nfelt and removed request for nfelt September 18, 2019 20:34
@stephanwlee stephanwlee requested a review from nfelt September 18, 2019 20:45
nfelt
nfelt approved these changes Sep 18, 2019
View reviewed changes
Copy link
Contributor

@nfelt nfelt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@stephanwlee stephanwlee merged commit 62357f6 into tensorflow:master Sep 18, 2019
@stephanwlee stephanwlee deleted the sym branch September 18, 2019 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@nfelt nfelt nfelt approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes core:summaries tf-2.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Switch tb.summary to reflect tb.summary.v2

3 participants

@stephanwlee @nfelt @googlebot