Fix Fairness optimization dialogs (What-If Tool) #2694
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From previous explanation was, we could understand that equal opportunity meant equal _precision_ (`TP/(TP+FP)`), which is not the case. The measure being equalized in Equal Opportunity is `TP/(TP+FN)`, which is called _sensitivity_.
When tapping on an info button, the first paper-dialog DOM in the button's grandparent was opening. This caused a problem when all elements had the same grandparent, so that clicking any one of them would open the first dialog. I've tested the other cases and they are all working fine.
jameswex
reviewed
Sep 24, 2019
...ractive_inference/tf_interactive_inference_dashboard/tf-interactive-inference-dashboard.html
Outdated
Show resolved
Hide resolved
|
For completeness: the Settings dialog is not concerned here, because it uses a separate function ( |
jameswex
approved these changes
Sep 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for features / changes
All Fairness optimization info icons were opening the first one (Custom threshold) when clicked.
Also updated description for Equal Opportunity optimisation, which was inaccurate.
Technical description of changes
Made function
openDialogopen the next sibling to the clicked element.Also checked that all
paper-dialogDOMs were positioned where they should, so that this function would work for all cases -- the only two cases I moved would actually work as they were, but we'd rather have positioned in the same way as the others (they were children; we want siblings).Screenshots of UI changes
Only actual change is the Equal Opportunity description.
Detailed steps to verify changes work correctly (as executed by you)
Open each dialog and confirm it's the one supposed to open:
Alternate designs / implementations considered
N/A