KEMBAR78
Fix slicing buckets in WIT by jameswex · Pull Request #2704 · tensorflow/tensorboard · GitHub
Skip to content

Conversation

@jameswex
Copy link
Contributor

  • Motivation for features / changes

Slicing by numeric features didn't always give the right result.

  • Technical description of changes

If number of buckets >= number of unique values, don't do ranges, slice by unique values.
In this case, make sure to delete bucket range information.

  • Detailed steps to verify changes work correctly (as executed by you)

Test in demo crossing the unique value threshold in both directions.

@jameswex jameswex merged commit 1d49a25 into tensorflow:master Sep 28, 2019
@jameswex jameswex deleted the fix_buckets branch September 28, 2019 00:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants