KEMBAR78
plugin: experimental plugin lib by psybuzz · Pull Request #2708 · tensorflow/tensorboard · GitHub
Skip to content

plugin: experimental plugin lib #2708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 1, 2019
Merged

plugin: experimental plugin lib #2708

merged 1 commit into from
Oct 1, 2019

Conversation

@psybuzz
Copy link
Contributor

@psybuzz psybuzz commented Oct 1, 2019 •
edited by stephanwlee
Loading

  • Motivation for features / changes
    One step towards a plugin library. Note this version is experimental, unstable, and IS intended to change.

  • Technical description of changes

    • Splits code into
      • plugin_util/
        • :messsage.js (used by both host and guest)
        • everything else: used only by main TensorBoard frame
      • plugin_lib/
        • used only by the plugin frame

Introduces experimental API methods

  • tb_plugin.lib.runs.getRuns(): retrieves list of runs from TensorBoard
    -tb_plugin.lib.runs.setOnRunsChanged(): listen to possible runsStore changes in the TensorBoard. This happens when new runs are retrieved from a reload.

WANT_LGTM=stephanwlee

@psybuzz psybuzz requested review from stephanwlee and removed request for stephanwlee October 1, 2019 02:37
@stephanwlee
Copy link
Contributor

Before I review this, would you be able to rebase this on top of master? I find it hard to discern the differences :(

@psybuzz psybuzz requested a review from stephanwlee October 1, 2019 07:17
stephanwlee
stephanwlee approved these changes Oct 1, 2019
View reviewed changes
@stephanwlee stephanwlee mentioned this pull request Oct 1, 2019
Closed
@psybuzz
plugin: message channels for dynamic plugins
482c9b0 
rename

manual merge

indent

core: implement experimental API for runs.

With tb.plugin.lib.run, you can now fetch list of runs and subscribe to
changes.

Do note that this change includes changes to the BUILD where we no
longer use modules for the library. We will revisit this in near future
to make this more usuable for non-TB Polymer projects

improve organization folders
@psybuzz psybuzz merged commit 1208152 into tensorflow:master Oct 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@stephanwlee stephanwlee stephanwlee approved these changes

Assignees

No one assigned

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@psybuzz @stephanwlee @googlebot