KEMBAR78
do not misconstrue Optimizer slot values as embeddings by hfiller · Pull Request #3679 · tensorflow/tensorboard · GitHub
Skip to content

do not misconstrue Optimizer slot values as embeddings #3679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 1, 2020
Merged

do not misconstrue Optimizer slot values as embeddings #3679

merged 1 commit into from
Jun 1, 2020

Conversation

@hfiller
Copy link
Contributor

@hfiller hfiller commented May 29, 2020

.OPTIMIZER_SLOT values in TF2 checkpoints have the same shape as embeddings, but are not embeddings.

@hfiller hfiller requested a review from nfelt May 29, 2020 14:19
@hfiller hfiller mentioned this pull request May 29, 2020
Merged
@hfiller hfiller merged commit 4c50549 into master Jun 1, 2020
@stephanwlee stephanwlee deleted the hfiller-optimizer branch June 17, 2020 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@nfelt nfelt nfelt approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes plugin:projector

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hfiller @nfelt @googlebot