docs: clarify that matmul, etc. are not summary ops
#3681
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When I first read, it sounded as if matmult was a summary operator. adding 'just' and 'and', I feel, makes all the difference.
wchargin
changed the title
wchargin
changed the title
matmul, etc. are not summary ops
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I first read, it sounded as if matmult was a summary operator. adding 'just' and 'and', I feel, makes all the difference.
Motivation for features / changes
I had to read a couple of times. Also difficult for ESL readers though perhaps grammatically correct.
Technical description of changes
Clarify that matmult is NOT a summary op.