KEMBAR78
Fix unnecessary scrollbar in firefox and chrome by japie1235813 · Pull Request #4525 · tensorflow/tensorboard · GitHub
Skip to content

Conversation

@japie1235813
Copy link
Contributor

  1. Replace margin with padding for the content of projector text block to prevent the body height exceeds the iframe
  2. The script tag ahead of nested iframe creates a small extra height for firefox. Apply line-heigh 0 to the body
  • Screenshots of UI changes
  • Chrome
    chrome
    Firefox
    firefox

@stephanwlee
Copy link
Contributor

On my mac, when I enable scrollbar always, I still see one scrollbar.
image

image

Instead of line-height: 0;, I think more correct thing to do is to convert iframe into display: block (default is inline it seems, at least on FF).

WDYT?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be avoided if possible and is something that can be replaced with display: block.

@japie1235813 japie1235813 merged commit 860a106 into tensorflow:master Jan 12, 2021
@stephanwlee stephanwlee linked an issue Jan 12, 2021 that may be closed by this pull request
@stephanwlee stephanwlee changed the title Fix unnecessary scroller bar in firefox and chrome Fix unnecessary scrollbar in firefox and chrome Jan 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Projector plugin has triple scrollbar(!!!) on Firefox

2 participants