core: fix the header pagination #4849
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TensorBoard customizes the material tab header component to have less visual jank and have consistent behavior as the Polymer based TensorBoard. This caused the scroll calculation to be incorrect (about 36 * 2 pixels) and a plugin like "text" where the tab label is very short caused the bug to manifest quite obviously. This change fixes that by changing how the mat-header is styled by overriding few of its internals. Fixes tensorflow#4841.
|
Gentle ping! :D |
psybuzz
approved these changes
Apr 15, 2021
Currently, they are all set to "primary" at the Material level. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TensorBoard customizes the material tab header component to have less
visual jank and have consistent behavior as the Polymer based
TensorBoard. This caused the scroll calculation to be incorrect (about
36 * 2 pixels) and a plugin like "text" where the tab label is very
short caused the bug to manifest quite obviously.
This change fixes that by changing how the mat-header is styled by
overriding few of its internals.
Fixes #4841.