timeseries: improved formatting on tooltip #5003
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmd3k
approved these changes
May 24, 2021
Previously, we were showing close to the "raw" value in the tooltip often leading to very long nonsense especially with the floating point math errors. The impact of said errors are often seeing a number like '0.3000000000004' where the last digit `4` often is meaningless. To work around this, we are using d3.format to remove unnecessary precision which just often adds visual noises.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we were showing close to the "raw" value in the tooltip
often leading to very long nonsense especially with the floating point
math errors. The impact of said errors are often seeing a number like
'0.3000000000004' where the last digit
4often is meaningless. To workaround this, we are using d3.format to remove unnecessary precision
which just often adds visual noises.