line chart: improve major axis for numbers #5010
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the extents are small and is close to 0, we were falling into the case where major axes were missing and minor axis formats were simply off. They were supposed to have truncated number but instead had `.…0000535` because we were removing common prefix between "0" and "0.0000535" and blindly adding `…` in it. This change addresses the corner case by adding test specs and special casing major ticks being `0`s.
bmd3k
approved these changes
May 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the extents are small and is close to 0, we were falling into the
case where major axes were missing and minor axis formats were simply
off. They were supposed to have truncated number but instead had
.…0000535because we were removing common prefix between "0" and"0.0000535" and blindly adding
…in it.This change addresses the corner case by adding test specs and special
casing major ticks being
0s.Previous:
New:
