KEMBAR78
timeseries: keep runs table header sticky by stephanwlee · Pull Request #5024 · tensorflow/tensorboard · GitHub
Skip to content

Conversation

@stephanwlee
Copy link
Contributor

@stephanwlee stephanwlee commented May 27, 2021

This change makes the runs table header sticky to the scrollable
container.

Tested sync and it exhibits no discernible visual changes at all.

This change makes the runs table header sticky to the scrollable
container.
@google-cla google-cla bot added the cla: yes label May 27, 2021
@stephanwlee stephanwlee requested a review from psybuzz May 27, 2021 19:18
Copy link
Contributor

@psybuzz psybuzz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was hoping we might be able to make the header row itself sticky, rather than the individual children inside it. However, it didn't work when I tried it, so this lgtm.

Would it be easy and make sense to have the "Select all runs" button and "All runs in this page are selected but not all runs..." sticky as well, since it is semantically similar to the header?

@stephanwlee
Copy link
Contributor Author

I was hoping we might be able to make the header row itself sticky, rather than the individual children inside it. However, it didn't work when I tried it, so this lgtm.

LOL, you actually tried what I wrestled with. I, too, found that weird.

@stephanwlee
Copy link
Contributor Author

Unfortunately, the select-all flow is a lot harder to support with position: sticky and CSS table (as opposed to <table>). I may just reorder the elements and will require different kind of changes. Will do that in a follow up.

@stephanwlee stephanwlee merged commit 7b27ce9 into tensorflow:master May 27, 2021
@stephanwlee stephanwlee deleted the sticky branch May 27, 2021 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants