[INTEL oneDNN] Disable oneDNN blocked format support #53288
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mihaimaruseac
approved these changes
Dec 5, 2021
google-ml-butler
bot
added
kokoro:force-run
|
@gzmkl Just curious, do you plan to document somewhere (e.g. on your website) that this environment variable is no longer supported? I wonder if we should make the code print a warning if users have this var set for 2.8 (that setting the var has no effect) and remove the print in 2.9. We can also add this change to TF release note as a minor change note, I guess. |
gbaned
added
ready to pull
|
@penpornk Hi Penporn, thank you for the approval. Yes, it is proper to add this change in TF release notes. Please help! |
This was referenced Feb 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR intends to disable oneDNN blocked format support in TensorFlow 2.8.
We will refactor related code in TensorFlow 2.9 (Note: refactoring work has been done but PR is BIG;
we do not submit it because TF 2.8 cutting date is coming).