Allows parse_dotenv(stream=StringIO())
#78
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alanjds
changed the title
parse_dotenv(stream=StringIO())
alanjds
changed the title
parse_dotenv(stream=StringIO())parse_dotenv(stream=StringIO())
|
This looks good. Some tests are failing due to installation flake8 issues on travis for python 3.4, that I'll fix up. Would it be possible for you to add some test cases and related documentation as well, for this so others can followup and use this functionality. |
|
Sure. But not "right now". Probable after the new year I can get back to work in tests/docs. Thanks for reviewing it. |
|
Docs and Tests included. |
theskumar
approved these changes
Mar 3, 2018
|
Thanks @alanjds, look great merging this in. Will update changelog in master and make a release. :) Also i think, i'm going to update with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backwards-compatible API for
parse_dotenv()that allows a stream having a dotfile to be parsed.The other option would be to save my already-existing stream in disk and providing the filepath, but this could have security and performance considerations.