refactor!: remove deprecated custom-field internal-tab event (#9413)

web-padawan · web-flow · commit 93eec4c764da · 2025-06-07T09:17:16.000+03:00
diff --git a/packages/custom-field/src/vaadin-custom-field-mixin.js b/packages/custom-field/src/vaadin-custom-field-mixin.js
@@ -220,11 +220,10 @@ export const CustomFieldMixin = (superClass) =>
           (inputs.indexOf(e.target) < inputs.length - 1 && !e.shiftKey) ||
           (inputs.indexOf(e.target) > 0 && e.shiftKey)
         ) {
-          this.dispatchEvent(new CustomEvent('internal-tab'));
-        } else {
-          // FIXME(yuriy): remove this workaround when value should not be updated before focusout
-          this.__setValue();
+          return;
         }
+        // FIXME(yuriy): remove this workaround when value should not be updated before focusout
+        this.__setValue();
       }
     }
 
diff --git a/packages/custom-field/src/vaadin-custom-field.d.ts b/packages/custom-field/src/vaadin-custom-field.d.ts
@@ -31,21 +31,11 @@ export type CustomFieldValueChangedEvent = CustomEvent<{ value: string }>;
  */
 export type CustomFieldValidatedEvent = CustomEvent<{ valid: boolean }>;
 
-/**
- * Fired on Tab keydown triggered from the internal inputs, meaning focus will not leave the inputs.
- * @deprecated
- */
-export type CustomFieldInternalTabEvent = Event & {
-  target: CustomField;
-};
-
 export interface CustomFieldCustomEventMap {
   'invalid-changed': CustomFieldInvalidChangedEvent;
 
   'value-changed': CustomFieldValueChangedEvent;
 
-  'internal-tab': CustomFieldInternalTabEvent;
-
   validated: CustomFieldValidatedEvent;
 }
 
diff --git a/packages/custom-field/test/keyboard.test.js b/packages/custom-field/test/keyboard.test.js
@@ -1,6 +1,5 @@
 import { expect } from '@vaadin/chai-plugins';
 import { fixtureSync, nextRender, tabKeyDown } from '@vaadin/testing-helpers';
-import sinon from 'sinon';
 import '../src/vaadin-custom-field.js';
 
 describe('keyboard navigation', () => {
@@ -19,39 +18,6 @@ describe('keyboard navigation', () => {
       await nextRender();
     });
 
-    describe('internal-tab event', () => {
-      let spy;
-
-      beforeEach(() => {
-        spy = sinon.spy();
-        customField.addEventListener('internal-tab', spy);
-      });
-
-      it('should fire on Tab', () => {
-        for (let i = 0; i < 3; i++) {
-          tabKeyDown(customField.inputs[i]);
-        }
-        expect(spy.callCount).to.equal(3);
-      });
-
-      it('should not fire on Tab from the last input', () => {
-        tabKeyDown(customField.inputs[3]);
-        expect(spy.called).to.be.false;
-      });
-
-      it('should fire on Shift Tab', () => {
-        for (let i = 3; i > 0; i--) {
-          tabKeyDown(customField.inputs[i], ['shift']);
-        }
-        expect(spy.callCount).to.equal(3);
-      });
-
-      it('should not fire on Shift Tab from the first input', () => {
-        tabKeyDown(customField.inputs[0], ['shift']);
-        expect(spy.called).to.be.false;
-      });
-    });
-
     describe('value change', () => {
       it('should update the value on Tab from the last input', () => {
         customField.inputs[3].value = 1;
diff --git a/packages/custom-field/test/typings/custom-field.types.ts b/packages/custom-field/test/typings/custom-field.types.ts
@@ -2,7 +2,6 @@ import '../../vaadin-custom-field.js';
 import type {
   CustomField,
   CustomFieldChangeEvent,
-  CustomFieldInternalTabEvent,
   CustomFieldInvalidChangedEvent,
   CustomFieldValidatedEvent,
   CustomFieldValueChangedEvent,
@@ -27,11 +26,6 @@ customField.addEventListener('value-changed', (event) => {
   assertType<string>(event.detail.value);
 });
 
-customField.addEventListener('internal-tab', (event) => {
-  assertType<CustomFieldInternalTabEvent>(event);
-  assertType<CustomField>(event.target);
-});
-
 customField.addEventListener('validated', (event) => {
   assertType<CustomFieldValidatedEvent>(event);
   assertType<boolean>(event.detail.valid);
