refactor!: convert Lumo compact preset to CSS files #10132
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jouni
requested changes
Sep 8, 2025
| */ | ||
|
|
||
| /* Use a stronger selector so that imports added later do not override the property values */ | ||
| :where(:root, :host):not(div) { |
There was a problem hiding this comment.
Using :where() would not increase specificity. Though, with :is() the specificity is even higher than before, 0, 1, 1 vs 0, 0, 2. I don't think that’s an issue.
Suggested change
| :where(:root, :host):not(div) { | |
| :is(:root, :host):not(div) { |
There was a problem hiding this comment.
Other Lumo CSS modules use where(). Updated to use :is() here - it should be enough to override that.
|
jouni
approved these changes
Sep 8, 2025
|
This ticket/PR has been released with Vaadin 25.0.0-alpha10. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #1682
Type of change