KEMBAR78
refactor!: remove Lumo global .js style modules by web-padawan · Pull Request #10138 · vaadin/web-components · GitHub
Skip to content

Conversation

@web-padawan
Copy link
Member

@web-padawan web-padawan commented Sep 9, 2025

Description

Removed Lumo .js style modules, except for mixins (used by some add-ons) which are deprecated.

Type of change

  • Breaking change

@web-padawan web-padawan changed the title refactor: remove Lumo global .js style modules refactor!: remove Lumo global .js style modules Sep 9, 2025
@web-padawan web-padawan force-pushed the refactor/drop-lumo-js branch from c8a3de6 to f3c92c8 Compare September 9, 2025 11:21
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not understand why we keep the individual utility modules. Wasn't the idea to modify react-components to add a static version of Utility.module.css to the repo instead?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, we could then drop utilities too. My only concern with copying is that file can be out of sync if we make dome changes, unless we generate it from utility.css from Lumo package.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generating it from the CSS file also shouldn't be too much of an issue. I'll try to take a look at that.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Created vaadin/react-components#358 to generate the utilities CSS modules from the CSS sources.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, merged and removed utilities in this PR as well.

@sonarqubecloud
Copy link

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a bit confused what the purpose of this is now, as it just imports random bits and pieces that are remaining. I don't think the package needs to have an entrypoint. Then again I'm lacking context on icon set and such.

Maybe something to discuss in the Daily.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The iconset is the only part still loaded by Lumo class. I agree that we could drop an entrypoint, I just wasn't sure.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll merge this PR for now, let's discuss removal of all-imports.js on Monday. One of its benefits is to ensure user apps load vaadin-iconset with the following JS import (even though it's not a common scenario):

import '@vaadin/vaadin-lumo-styles';

@web-padawan web-padawan merged commit 2277a21 into main Sep 12, 2025
9 checks passed
@web-padawan web-padawan deleted the refactor/drop-lumo-js branch September 12, 2025 10:50
@vaadin-bot
Copy link
Collaborator

This ticket/PR has been released with Vaadin 25.0.0-alpha10.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants